Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the JUnit 5 XML output #246

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

tjoneslo
Copy link
Contributor

@tjoneslo tjoneslo commented Feb 8, 2024

THe output for the Junit5 XML did not match the output from the Gradle (our gold standard) or Maven (a secondary goal). This took digging further into the JUnit internal test setup and deciphering how each test is processed, and pushing it back into the form we want it in. It would be nice if JUnit itself did this but ...

Copy link
Collaborator

@shs96c shs96c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but can we please trim the properties in the xml files? We had to do that before, and it's always nice not to leak too much data.

THe output for the Junit5 XML did not match the output from the Gradle (our gold standard) or Maven (a secondary goal). This took digging further into the JUnit internal test setup and deciphering how each test is processed, and pushing it back into the form we want it in. It would be nice if JUnit itself did this but ...
Copy link
Collaborator

@shs96c shs96c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@shs96c shs96c merged commit 2a60641 into bazel-contrib:main Feb 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants