Handle java_library being remapped with map_kind #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
LGTM, thanks!
It looks like you're missing a (empty) file at java/gazelle/testdata/lib_with_runtime_deps_and_map_kind/WORKSPACE which means this isn't being picked up as a new test?
And if you add that, I think there's an extra trailing -data and the end of java/gazelle/testdata/lib_with_runtime_deps_and_map_kind/expectedStderr.txt
Otherwise, happy to merge - thanks!
|
Ahh, indeed, sorry, lost the WORKSPACE during migration of the patch from one repo to another, thanks for spotting it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When preserving runtime dependencies of existing rules use the new rule name if it was remapped.