junit5: pass static nested classes to the launcher #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change iterates over all the static nested classes of the test class and adds them to LauncherDiscoveryRequestBuilder to allow running tests within static nested classes. While Java allows more than one level of nesting, we limit our search to one level of nesting at the moment. Junit4 tests annotated with `RunWith(Enclosed.class)` need to be special cased. Refer: gradle/gradle#4427
gaurav-narula
force-pushed
the
junit5-static-nested-classes-oss
branch
from
12498e3
to
88d60fb
Compare
shs96c
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change iterates over all the static nested classes of the test class and adds them to LauncherDiscoveryRequestBuilder to allow running tests within static nested classes.
While Java allows more than one level of nesting, we limit our search to one level of nesting at the moment.
Junit4 tests annotated with
RunWith(Enclosed.class)need to be special cased.Refer: gradle/gradle#4427