fix(testresult): add skipped message to <skipped> not <failure>

[gibfahn]

Currently skipped tests with messages return
<skipped></skipped><failure message="...">, but all the other examples
of JUnit I can find return <skipped message="...">.

The inclusion of both a <skipped> and <failure> confuses parsers,
making them think that the test failed when it was actually skipped.

Skipping tests was added in
#37.

XML changes

To show the difference

git switch main
bazel test java/test/com/github/bazel_contrib/contrib_rules_jvm/junit5/... &>/dev/null
cat .bazel/testlogs/java/test/com/github/bazel_contrib/contrib_rules_jvm/junit5/AssumptionsJUnit5Test/test.xml

git switch skipped_message
bazel test java/test/com/github/bazel_contrib/contrib_rules_jvm/junit5/... &>/dev/null
cat .bazel/testlogs/java/test/com/github/bazel_contrib/contrib_rules_jvm/junit5/AssumptionsJUnit5Test/test.xml

Before

<?xml version="1.0" encoding="utf-8"?>
<testsuites>
    <testsuite name="com.github.bazel_contrib.contrib_rules_jvm.junit5.AssumptionsJUnit5Test"
    tests="2" failures="1" errors="0" disabled="0" skipped="1"
    package="">
        <properties />
        <testcase name="shouldBeSkipped"
        classname="com.github.bazel_contrib.contrib_rules_jvm.junit5.AssumptionsJUnit5Test"
        time="0">
            <!-- We say skipped here but also failure. -->
            <skipped></skipped>
            <failure message="Assumption failed: assumption is not true"
            type="org.opentest4j.TestAbortedException">
                <![CDATA[org.opentest4j.TestAbortedException: Assumption failed: assumption is not true
                        at org.junit.jupiter.api.Assumptions.throwTestAbortedException(Assumptions.java:258)
                        ...
                        at com.github.bazel_contrib.contrib_rules_jvm.junit5.JUnit5Runner.main(JUnit5Runner.java:39)
                ]]>
            </failure>
        </testcase>
    </testsuite>
</testsuites>

After

<?xml version="1.0" encoding="utf-8"?>
<testsuites>
    <testsuite name="com.github.bazel_contrib.contrib_rules_jvm.junit5.AssumptionsJUnit5Test"
    tests="2" failures="0" errors="0" disabled="0" skipped="1"
    package="">
        <properties />
        <testcase name="shouldBeSkipped"
        classname="com.github.bazel_contrib.contrib_rules_jvm.junit5.AssumptionsJUnit5Test"
        time="0">
            <!-- We just say skipped here, and include the skipped message directly.. -->
            <skipped message="Assumption failed: assumption is not true"
            type="org.opentest4j.TestAbortedException">
                <![CDATA[org.opentest4j.TestAbortedException: Assumption failed: assumption is not true
                        at org.junit.jupiter.api.Assumptions.throwTestAbortedException(Assumptions.java:258)
                       [...]
                        at com.github.bazel_contrib.contrib_rules_jvm.junit5.JUnit5Runner.main(JUnit5Runner.java:39)
                ]]>
            </skipped>
        </testcase>
    </testsuite>
</testsuites>

---

Commits (oldest to newest)

2ee885a fix(testresult): add skipped message to not

Currently skipped tests with messages return
<skipped></skipped><failure message="...">, but all the other examples
of JUnit I can find return <skipped message="...">.

The inclusion of both a <skipped> and <failure> confuses parsers,
making them think that the test failed when it was actually skipped.

Skipping tests was added in
#37.

[illicitonion]

Thanks!