-
Notifications
You must be signed in to change notification settings - Fork 59
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Handle java_library being remapped with map_kind when preserving runt…
…ime dependencies
- Loading branch information
Ignas Mikalajunas
committed
Aug 29, 2023
1 parent
90eae92
commit 7d37ec7
Showing
5 changed files
with
38 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
java/gazelle/testdata/lib_with_runtime_deps_and_map_kind/expectedStderr.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
[90m12:00AM[0m [31mWRN[0m [1mjava/gazelle/private/maven/resolver.go:XXX[0m[36m >[0m not loading maven dependencies [36merror=[0m[31m"open %WORKSPACEPATH%/maven_install.json: no such file or directory"[0m [36m_c=[0mmaven-resolver-data |
10 changes: 10 additions & 0 deletions
10
...elle/testdata/lib_with_runtime_deps_and_map_kind/src/main/java/com/example/hello/BUILD.in
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
load("//libs/bazel/java:rules_java.bzl", "generic_java_library") | ||
|
||
# gazelle:map_kind java_library generic_java_library //libs/bazel/java:rules_java.bzl | ||
|
||
generic_java_library( | ||
name = "hello", | ||
srcs = ["Hello.java"], | ||
visibility = ["//:__subpackages__"], | ||
runtime_deps = ["//foo/bar"], | ||
) |
10 changes: 10 additions & 0 deletions
10
...lle/testdata/lib_with_runtime_deps_and_map_kind/src/main/java/com/example/hello/BUILD.out
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
load("//libs/bazel/java:rules_java.bzl", "generic_java_library") | ||
|
||
# gazelle:map_kind java_library generic_java_library //libs/bazel/java:rules_java.bzl | ||
|
||
generic_java_library( | ||
name = "hello", | ||
srcs = ["Hello.java"], | ||
visibility = ["//:__subpackages__"], | ||
runtime_deps = ["//foo/bar"], | ||
) |
7 changes: 7 additions & 0 deletions
7
...le/testdata/lib_with_runtime_deps_and_map_kind/src/main/java/com/example/hello/Hello.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
package com.example.hello; | ||
|
||
public class Hello { | ||
public static void sayHi() { | ||
System.out.println("Hi!"); | ||
} | ||
} |