feat: Add an executable_test rule and use it in write_source_file #1090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he executable permission is correct.
calliecameron
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds executable_test, which checks that a file or directory's executable permissions are as intended. Implementation is mostly copied from diff_test. Tested on Linux, since that's what I have. As far as I remember, the executable permission doesn't exist on Windows, so I've made the Windows version of the test always pass.
Added this to write_source_files, so that when diff_test is true, the executable permission will be checked as well as diffing the contents.
I considered having a separate executable_test arg instead of controlling them both with diff_test - can switch to that if you prefer.
Fixes #1089.