Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in evaluation for tie in scores. #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix bug in evaluation for tie in scores. #10

wants to merge 2 commits into from

Conversation

kdexd
Copy link
Member

@kdexd kdexd commented Jul 25, 2018

If the score of ground truth would tie with another option, it always got assigned a higher rank. This caused evaluation metrics to be reported higher than their true values. This PR fixes that.

@nirbhayjm
Copy link
Member

So this change would require re-evaluating all checkpoints and updating the reported numbers in the README, right?

@abhshkdz
Copy link
Member

I just reviewed batra-mlp-lab/visdial#36 and tried simplifying things a bit: batra-mlp-lab/visdial@3a769d2. Those changes probably apply here too.

@kdexd
Copy link
Member Author

kdexd commented Jul 26, 2018

@nirbhayjm yes it does. If we never faced ties in scores, then they won't change. But usually there are ties...

@nirbhayjm nirbhayjm mentioned this pull request Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants