Subscription Payment also looks at renewal orders for mandate. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've noticed the following scenario: - Customer pays for subscription initially. - A mandate will be given and saved on the parent Order. - If for some reason the payment fails (this could be the bank just refusing the payment due to more strict authentication nowadays) and requires manual payment, there will be a new mandate within Mollie & within the Renewal Order. - When renewing the subscription again (after the interval is due again) the newly created mandate won't be used for the latest renewal order payment. - The old mandate will be used again (which is expired/revoked). I decided it would be better to also check for mandates on the renewal orders instead of changing the parent order mandate. Since this would remove history of what mandates are used.
|
Oh and I also fixed a small type of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed the following scenario:
I decided it would be better to also check for mandates on the renewal orders instead of changing the parent order mandate. Since this would remove history of what mandates are used.