Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for arangodb 3.3 - rely on JSON.parse() instead of string parsing #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

voondo
Copy link

@voondo voondo commented May 9, 2018

Although arangochair works fine with arangodb 3.1, I had errors with 3.3. It seems the format changed a bit and the current string parser fails.

Here is a fix relying on JSON.parse() instead of parsing the string which seems more robust against format changes.

@voondo voondo changed the title Fixes for 3.3 - rely on JSON.parse() instead of string parsing Fix for arangodb 3.3 - rely on JSON.parse() instead of string parsing May 9, 2018
@yerboogieman
Copy link

Hi @voondo, my PR entitled "Emit separate events for inserts and updates" also has code to use JSON.parse() instead of relying on index-based string parsing. Perhaps we could merge our pull requests into one somehow so they do not conflict?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants