Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc. README improvements, including installation and usage info #135

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

daveyarwood
Copy link

It took me a while to figure out how to install and use sxhkd. After skimming through the issues and finding #24, I saw comments from @baskerville explaining what dependencies are needed. I think it would be super helpful if this information were available in the README, so here's a PR!

I added various formatting improvements and usage info while I was at it. Feedback welcome.

@dogweather
Copy link

Thanks - great idea!

@daveyarwood
Copy link
Author

I've merged in the latest master and resolved conflicts.

@baskerville I still think it would be helpful to add this information to the README. Any objection to merging my PR?

@pataquets
Copy link
Contributor

@baskerville: Friendly ping. I'm sure many newcomers had stumbled on this.

@daveyarwood
Copy link
Author

@Ascenio You approved this PR - does that mean you have push access to the repo? Maybe you could merge this PR?

@daveyarwood
Copy link
Author

daveyarwood commented Sep 12, 2023

I merged master in again and resolved conflicts. 4 years later, I still believe the README would benefit from my improvements, most importantly, the setup instructions.

@baskerville If you have a couple minutes, could you please review and merge my PR? Thanks!

@Ascenio
Copy link

Ascenio commented Sep 13, 2023

@Ascenio You approved this PR - does that mean you have push access to the repo? Maybe you could merge this PR?

No, I don't have any. I just took a look and thought it was ok xD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants