Add support for XIconifyWindow and unminimizing from taskbars #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! Currently, minimized windows on bspwm don't really work great with bars that provide task managers (task lists) like tint2, KDE/Xfce panel widgets etc.
Tasklists usually allow you to click on a task to minimize or focus & unminimize a window. On bspwm it works differently: window is focused only if it's not hidden and you get switched to the window's desktop (even if it's hidden).
The patch adds the conventional behavior described above. As a side effect, it also makes focused windows automatically unhide (so now they can also be unhidden with rofi etc.) but other than that it shouldn't introduce any changes for people who don't use task managers.
Edit: I doubt it's going to get merged, e.g. i3 actually reverted the commit that added handling of WM_CHANGE_STATE. (or maybe my patch is just bad idk, i'm not experiencing any issues.) If you want this, you can just apply the patch manually.