Insert placeholders for stickies #1032
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DelusionalLogic
force-pushed
the
placeholders
branch
from
b141b36
to
666176c
Compare
Removing a sticky window from the desktop tree causes the entire layout to go out the window, which makes sticky essentially useless for tiled windows. Instead I suggest we insert a receptacle bound to the node when moving a sticky window around. When moving that sticky window back we reinsert it into that receptacle. This way we get to keep the layout we set up, while still moving all the sticky windows around. When removing the windows (or just the sticky flag) we now have to remember to remove the placeholders from all desktops on that monitor. There's probably many more cases where we have to remove the placeholders. I'd like feedback on that.
DelusionalLogic
force-pushed
the
placeholders
branch
from
666176c
to
04a9ad9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing a sticky window from the desktop tree causes the entire layout
to go out the window, which makes sticky essentially useless for tiled
windows. Instead I suggest we insert a receptacle bound to the node when
moving a sticky window around. When moving that sticky window back
we reinsert it into that receptacle. This way we get to keep the layout
we set up, while still moving all the sticky windows around.
When removing the windows (or just the sticky flag) we now have to
remember to remove the placeholders from all desktops on that monitor.
There's probably many more cases where we have to remove the
placeholders. I'd like feedback on that.
I think the functionality here is very useful, but the implementation
doesn't strike me as elegant. I'd like someone more familiar with the
codebase to either provide feedback or adopt this changeset.