-
Notifications
You must be signed in to change notification settings - Fork 133
feat: Add Claude Code skills for Basic Memory MCP integration #445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Add three model-invoked skills that help Claude automatically use Basic Memory's MCP tools in the right contexts: - knowledge-capture: Capture insights, decisions, and learnings into structured notes with observations and relations - continue-conversation: Resume previous work by building context from the knowledge graph using memory:// URLs and recent activity - spec-driven-development: Guide implementation based on specs stored in Basic Memory, following the SPEC-1 process Unlike slash commands (user-invoked), skills are automatically discovered and applied by Claude based on conversation context. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> Signed-off-by: phernandez <[email protected]>
|
Claude finished @phernandez's task —— View job PR Review Complete ✅I've thoroughly reviewed this PR against Basic Memory's team checklist. Overall, this is an excellent addition that integrates Claude Code skills with Basic Memory's MCP tools. The skills are well-structured, comprehensive, and follow best practices. Tasks
Code Quality & Standards ✅
Testing & Documentation ✅
Basic Memory Architecture ✅
Security & Performance ✅
Compatibility ✅
Detailed FindingsStrengths 🌟
Issues & RecommendationsMinor: Unicode/Emoji UsageLocation: All three skill files Per CLAUDE.md compatibility guidelines:
Impact: Low - These are documentation files, not console output. However, for consistency with project standards: Recommendation: Consider replacing in examples:
Example from ### Feature Area
- [✓] Basic functionality implemented # Instead of ✅
- [✓] Props and events defined
- [ ] Add sorting controls
- [ ] Improve accessibility
- [x] Currently implementing responsive designHowever, I note that:
Verdict: This is a very minor issue. I'd defer to the team's preference on whether documentation files follow the same emoji restrictions as code/console output. Enhancement: Update CLAUDE.mdRecommendation: Consider adding a brief mention of these skills to CLAUDE.md's "MCP Capabilities" or "Basic Memory Product Usage" sections so developers know they exist. Suggested addition to CLAUDE.md: ### Claude Code Skills
Basic Memory provides Claude Code skills for enhanced AI-human collaboration:
- `knowledge-capture` - Automatically capture insights and decisions into structured notes
- `continue-conversation` - Resume work by building context from the knowledge graph
- `spec-driven-development` - Guide implementation following SPEC-1 process
Skills are model-invoked (Claude decides when to use them) unlike slash commands (user-invoked).Enhancement: Consider Adding Examples DirectorySuggestion: For future iterations, consider adding an Verdict: Approve ✅This PR is ready to merge. The skills are:
The minor unicode/emoji usage is not a blocker given that:
Recommended Next Steps:
Excellent work on this implementation! These skills will make Basic Memory much more powerful when used with Claude Code. |
Convert the Basic Memory skills into a proper Claude Code plugin format: - Add .claude-plugin/plugin.json manifest with metadata - Move skills from .claude/skills/ to root skills/ directory - Add PLUGIN.md with installation and usage documentation Plugin structure: ``` .claude-plugin/ plugin.json # Plugin manifest skills/ knowledge-capture/ continue-conversation/ spec-driven-development/ PLUGIN.md # Plugin documentation ``` Users can install via: /plugin install basic-memory@basicmachines 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> Signed-off-by: phernandez <[email protected]>
|
Claude finished @phernandez's task —— View job PR Review CompleteI've reviewed PR #445 against the Basic Memory team checklist. This is an excellent addition that packages Claude Code skills for Basic Memory MCP integration. Tasks
Review Against Team ChecklistCode Quality & Standards ✅
Testing & Documentation ✅
Basic Memory Architecture ✅
Security & Performance ✅
Compatibility ✅
Detailed ReviewStrengths1. Excellent Documentation Quality
2. Perfect MCP Tool Integration
3. Knowledge Graph Best Practices
4. Practical, Actionable Examples
5. Cross-Skill Integration Minor ObservationsUnicode/Emoji Usage Files affected: All three skill files Per CLAUDE.md compatibility guidelines:
Examples:
Assessment: This is a very minor issue. These are skill definition files meant for Claude Code to read, not console output. The PR description itself uses emojis (🤖), suggesting emojis in documentation may be acceptable. The checkmarks significantly improve readability in the markdown format. Recommendation: This is not a blocker. The team could optionally replace with text markers ( Enhancement Suggestions (Optional, Future Work)1. Update CLAUDE.md ### Claude Code Skills
Basic Memory provides Claude Code skills for enhanced AI-human collaboration:
- `knowledge-capture` - Automatically capture insights and decisions
- `continue-conversation` - Resume work by building context from knowledge graph
- `spec-driven-development` - Follow SPEC-1 specification-driven development process
Skills are model-invoked (Claude decides when to use them) vs. slash commands (user-invoked).2. Example Notes Directory Verdict: Approve ✅This PR is ready to merge. The skills are:
The minor unicode/emoji usage is not a blocker given:
Recommended Next Steps:
Excellent work on this implementation! These skills will make Basic Memory much more powerful when integrated with Claude Code. |
Add full plugin infrastructure for distribution: Marketplace: - Add marketplace.json for self-hosting at basicmachines-co/basic-memory - Users can add via: /plugin marketplace add basicmachines-co/basic-memory Slash Commands: - /remember [title] - Capture insights to Basic Memory - /continue [topic] - Resume previous work with context - /context <url> - Build context from memory:// URLs - /recent [timeframe] - Show recent activity Hooks: - PostToolUse: Confirm when notes are saved - Stop: Suggest /remember for valuable conversations Updated PLUGIN.md with comprehensive documentation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> Signed-off-by: phernandez <[email protected]>
|
Claude finished @phernandez's task —— View job PR Review Complete ✅I've thoroughly reviewed PR #445 against the Basic Memory team checklist. This PR refactors the previous skills implementation into a complete Claude Code plugin with marketplace distribution, slash commands, hooks, and skills. Tasks
Review Against Team ChecklistCode Quality & Standards ✅
Testing & Documentation ✅
Basic Memory Architecture ✅
Security & Performance ✅
Compatibility
|
Add two new skills for editing Basic Memory notes: edit-note (MCP-based): - Works with both cloud and local installations - Conversational editing workflow via MCP tools - Uses edit_note operations: append, prepend, find_replace, replace_section - Shows before/after state for user verification edit-note-local (file-based): - For local installations with file system access - Edits markdown files directly using Claude Code's Read/Edit/Write - Changes sync automatically via `basic-memory sync --watch` - Full file access including frontmatter editing 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> Signed-off-by: phernandez <[email protected]>
|
Claude finished @phernandez's task —— View job PR Review Complete ✅I've thoroughly reviewed PR #445 against the Basic Memory team checklist. This PR adds a complete Claude Code plugin for Basic Memory MCP integration, including the new edit-note skills added in the latest commit (4f2b1b2). Tasks
Review Against Team ChecklistCode Quality & Standards ✅
Testing & Documentation ✅
Basic Memory Architecture ✅
Security & Performance ✅
Compatibility
|
New skill to help users organize and maintain their knowledge base: Capabilities: - Find orphan notes (no relations to other notes) - Suggest relations based on content similarity - Identify duplicate or overlapping notes - Review and suggest folder organization - Normalize inconsistent tags - Create index/hub notes for topic navigation - Enrich sparse notes with observations and structure Includes workflows for: - Quick health check (overview of KB status) - Deep organization session (thorough review) - Topic-focused organization (organize around a subject) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> Signed-off-by: phernandez <[email protected]>
|
Claude finished @phernandez's task —— View job PR Review Complete ✅I've thoroughly reviewed PR #445 against the Basic Memory team checklist, including the latest knowledge-organizer skill added in commit 3a7fca8. Tasks
Review Against Team ChecklistCode Quality & Standards ✅
Testing & Documentation ✅
Basic Memory Architecture ✅
Security & Performance ✅
Compatibility
|
Use verb form for skill name to be consistent with action-oriented naming (like knowledge-capture, not knowledge-capturer). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> Signed-off-by: phernandez <[email protected]>
|
Claude finished @phernandez's task —— View job PR Review Complete ✅I've thoroughly reviewed PR #445 against the Basic Memory team checklist. This is an excellent Claude Code plugin implementation with comprehensive skills, commands, and hooks. Tasks
Review Against Team ChecklistCode Quality & Standards ✅
Testing & Documentation ✅
Basic Memory Architecture ✅
Security & Performance ✅
Compatibility
|
User-invoked command to complement the knowledge-organize skill. Actions: - /organize health - Quick overview of KB status (default) - /organize orphans - Find notes with no relations - /organize duplicates - Find similar/overlapping notes - /organize relations [note] - Suggest connections for a note - /organize tags - Review and normalize tag consistency Always confirms before modifying notes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> Signed-off-by: phernandez <[email protected]>
|
Claude finished @phernandez's task —— View job PR Review Complete ✅I've thoroughly reviewed PR #445 against the Basic Memory team checklist. This PR adds a complete Claude Code plugin with skills, slash commands, and hooks for Basic Memory MCP integration. Tasks
Review Against Team ChecklistCode Quality & Standards ✅
Testing & Documentation ✅
Basic Memory Architecture ✅
Security & Performance ✅
Compatibility
|
Reorganize plugin files into a dedicated subdirectory to keep them separate from the main Basic Memory Python package: - Move all plugin files to claude-code-plugin/ - Add README.md with quick start guide - Update installation paths to use subdirectory New structure: ``` claude-code-plugin/ ├── .claude-plugin/ │ ├── plugin.json │ └── marketplace.json ├── commands/ ├── skills/ ├── hooks/ ├── README.md └── PLUGIN.md ``` Installation: /plugin marketplace add basicmachines-co/basic-memory/claude-code-plugin /plugin install basic-memory@basicmachines 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> Signed-off-by: phernandez <[email protected]>
|
Claude finished @phernandez's task —— View job PR Review Complete ✅I've thoroughly reviewed PR #445 against the Basic Memory team checklist. This PR adds a complete Claude Code plugin for Basic Memory MCP integration. Tasks
Team Checklist ResultsCode Quality & Standards ✅
Testing & Documentation ✅
Basic Memory Architecture ✅
Security & Performance ✅
Compatibility
|
New capability to research topics and save structured reports: /research command: - /research <topic> [folder] - Investigates using web search, codebase search, and existing notes - Produces structured report with findings and analysis - Saves to research/ folder by default research skill (model-invoked): - Triggers on "research", "investigate", "look into", "explore" - Gathers information from multiple sources - Synthesizes findings into actionable reports - Links to sources and related notes Report structure: - Summary and research question - Key findings with evidence - Analysis and recommendations - Open questions and sources - Observations and relations for knowledge graph 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]> Signed-off-by: phernandez <[email protected]>
|
Claude finished @phernandez's task —— View job PR Review Complete ✅I've thoroughly reviewed PR #445 against the Basic Memory team checklist. This PR adds a comprehensive Claude Code plugin for Basic Memory MCP integration. Tasks
Team Checklist ResultsCode Quality & Standards ✅
Testing & Documentation ✅
Basic Memory Architecture ✅
Security & Performance ✅
Compatibility
Detailed FindingsPlugin OverviewThis PR delivers a complete Claude Code plugin ecosystem: ✅ 7 Skills (model-invoked):
✅ 6 Slash Commands (user-invoked):
✅ 2 Hooks (automated):
✅ Documentation:
Strengths 🌟1. Excellent Documentation Quality All documentation is exceptionally clear and comprehensive:
2. Proper MCP Tool Integration All components correctly reference existing Basic Memory MCP tools:
3. Knowledge Graph Best Practices Skills and commands promote correct Basic Memory markdown format: Observations: - [decision] What was decided and why #tag
- [insight] Key understanding gained #tag
- [pattern] Reusable approach identified #tag
- [learning] What we learned #tag
- [tradeoff] Options weighed #tagRelations: - relates-to [[Related Concept]]
- implements [[Parent Spec]]
- extends [[Other Note]]
- learned-from [[Source]]
- enables [[Capability]]Frontmatter: ---
title: Note Title
type: note
tags:
- relevant-tags
---4. Thoughtful Architecture The plugin demonstrates excellent design:
5. Knowledge Organization Capabilities The
Paired with 6. Research Integration The new
|
|
Cool! |
Summary
Complete Claude Code plugin for Basic Memory MCP integration, packaged as a self-hosted marketplace.
Skills (model-invoked)
Slash Commands (user-invoked)
/remember [title] [folder]- Capture insights from current conversation to Basic Memory/continue [topic]- Resume previous work by building context/context <memory://url> [depth] [timeframe]- Build context from a specific memory:// URL/recent [timeframe] [project]- Show recent activity in Basic MemoryHooks (automated)
/rememberto capture valuable insightsPlugin Structure
Installation
Test plan
/plugin marketplace add/plugin install basic-memory@basicmachines/remembercaptures conversation insights/continuebuilds context from previous work/contextwith memory:// URLs/recentshows activity🤖 Generated with Claude Code