Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed failed connections from the pool #784

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from

Conversation

seanmcevoy
Copy link

@seanmcevoy seanmcevoy commented May 28, 2018

Attempted fix for issue:
#723
the pid of the dead process was being left in the 'pending' list.
i haven't figured out the original scenario that put it into this state but this bug would have been responsible for the repetitive retries and 'noproc' crashes.

Mikael Lixenstrand and others added 21 commits January 18, 2016 12:05
Since riak_kv_vnode could have deleted a expired object.
…ords-riak-kv-vnode

Replace useage of macro with factory function
These warnings no longer exist. Might as well remove them from this
file.
…rnings

Remove old lines from dialyzer.ignore-warnings
Delete unused compose and multicompose functions
@martinsumner
Copy link
Contributor

Does the fail_request/3 call in L401 not remove the request from the pending list https://github.com/basho/riak_repl/blob/develop-3.0/src/riak_core_connection_mgr.erl#L654?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants