Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Late vnode replies show up as errors in the logs #20

Closed
wants to merge 1 commit into from

Conversation

evanmcc
Copy link
Contributor

@evanmcc evanmcc commented Dec 10, 2012

When a cluster is heavily loaded, sometimes a vnode will not respond within the client's receive timeout. In webmachine this isn't a problem, since the receiving pid is dead after the request is finished and the message is dropped. But since the pbc interface calls gets from a long-running pid, the gen_server must occasionally deal with these messages when it gets them.

So:

  • add a non-error handle_info clause for vnode replies that reach this process after a get's receive timeout has expired.
  • log those as info with a clearer message

this process after a get's receive timeout has expired.
@evanmcc
Copy link
Contributor Author

evanmcc commented Dec 10, 2012

cc @jtuple @kellymclaughlin

@evanmcc
Copy link
Contributor Author

evanmcc commented Dec 10, 2012

This is a partial fix for issue #16, I suppose.

@seancribbs
Copy link
Contributor

@evanmcc This seems to special-case get FSM replies, but is also stale. OK to close?

@evanmcc
Copy link
Contributor Author

evanmcc commented Dec 24, 2013

Yes, close it, it isn't the right fix.

@seancribbs seancribbs closed this Dec 24, 2013
@seancribbs seancribbs deleted the pevm_late_msg branch December 24, 2013 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants