Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rpc calls via nodetool #1107

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix rpc calls via nodetool #1107

wants to merge 2 commits into from

Conversation

martincox
Copy link
Contributor

@martincox martincox commented Apr 12, 2022

Relx 4.5+ makes use of erl_call, which supersedes nodetool, we have to force the use of nodetool as erl_call does not have support for catching stdio (not implemented in relx). This is done via the use of the USE_NODETOOL=1 flag in the run_rpc function.

Without any changes, calling console commands via the usual relx_nodetool rpc method:

image

Nodetool also changed rpc calls slightly by requiring args as a comma separated list, and changed the expected return from rpc calls, anything other than rpc_ok gets printed to the shell now :/ (it doesn't with this fix).

This was before (trailing ok is printed out from every command:
image

Fixed, by using a proxy function (to swallow the ok, and return rpc_ok instead) in a separate PR in riak_kv:
image

Martin Cox added 2 commits April 12, 2022 13:45
…rcedes

nodetool, we have to force the use of nodetool as erl_call does not have
support for catching stdio (not implemented in relx). Nodetool also changed
rpc calls slightly by requiring args as a list, and changed the expected
return from rpc calls, anything other than rpc_ok gets printed to the shell now :/
…dmin rel version back to the rel/files/riak-admin file, doh.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant