Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build TLS-enabled Riak node(s) #1014

Open
wants to merge 2 commits into
base: develop-3.0
Choose a base branch
from
Open

Conversation

hanssv
Copy link

@hanssv hanssv commented Mar 25, 2020

This is just proof of concept, but together with riak_test/use_inet_tls branch tests are being run against TLS-enabled Riak node(s). It remains to make this somewhat more user friendly/configurable.

Using TLS exposed a couple of problems with variables, and extension scripts, these were pre-existing but didn't manifest in an "all-default" setting.

@hanssv
Copy link
Author

hanssv commented Mar 25, 2020

DO NOT MERGE in current shape.

@@ -6,6 +6,7 @@
ORIGINAL_DIR=$(pwd)

# Make sure CWD is set to runner run dir
RUNNER_BASE_DIR={{runner_base_dir}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hanssv, did something break that required this to be added? I think the runner_base stuff is overspill from the former node_package stuff, but isn't necessarily required any more, to my knowledge (needs a bit of cleanup to remove it).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, without this it runs in my home-directory, which means it does not find the SSL-config and thus can't talk to the node (or well it will refuse to even try to talk to it).

It wasn't necessary before (and it was horribly broken since bbmustache had HTML-encoded the bash command!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants