Add dialyzer #34
Open
Add dialyzer #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t because of issues pulling type specs out of an include file (.hrl)
This patch does not fix all dialyzer warnings. It uses specs generated by Typer with some hand editing to clean them up. The -spec annotations try to match the original edoc specs where possible. However, some of the edoc annotations were out of date. The specs are underspecified in some places to allow dialyzer to run.
…entries by regex seach and replace.
| @sleep 1 | ||
| dialyzer --verbose -Wno_return --plt $(COMBO_PLT) $(INCLUDES) ebin | ||
|
|
||
| typer: $(DEPSOLVER_PLT) |
There was a problem hiding this comment.
Where do you define this variable? I only see COMBO_PLT.
…in rebar.config to debug_info and warnings_as_errors to align with Basho standard practices.
|
I fixed those issues in varnerac@fa2d69c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch does not fix all dialyzer warnings. It uses specs generated by Typer with some hand editing to clean them up. The -spec annotations try to match the original edoc specs where possible. However, some of the edoc annotations were out of date. The specs are underspecified in some places to allow dialyzer to run.
This makes riak-erlang-http-client fragile against changes in risk-erlang-client (protobuf). It should be, since it is designed to be a drop-in replacement.