Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -stdlib=libc++ flag when building snappy #258

Open
wants to merge 53 commits into
base: develop
Choose a base branch
from
Open

Conversation

jvf
Copy link

@jvf jvf commented Dec 11, 2019

Addendum Fixup to #245, adding the -stdlib=libc++ when building Snappy. This is necessary to build on macOS. Tested on macOS 10.14.6. See also #252 for the initial issue.

bougueil and others added 30 commits August 13, 2015 10:04
These should only be appearing in riak.conf for documentation, as they
won't be needed unless a user is setting up multi_backend. Even then
they will probably want to change the backend name to something other
than "name".
…pression-settings

Make multi_backend compression settings commented
Don't use deprecated erlang:now/0 in tests
unsigned long for memory_sz so it compiles on scaleway C1 / arm
…ters. This fills some remaining race condition holes (of which one recently seen).
Switch to reference counted pointers instead of naked pointers.
Port submit_to_thread_queue() from riak_ts-develop to develop
…factor

Backport submit_to_thread_queue() to KV
Manually disabling dylib creation for snappy since OSX links the preferentially rather than the static library.  This resolves basho#236
Matthew Von-Maszewski and others added 23 commits January 26, 2017 13:07
A commit over 4 years ago disabled most of the eunit tests in the eleveldb module.
This enables them and adds a few, while refactoring so they clean up after themselves.
It also adds exported test helper functions to make it easier for other tests to clean up after themselves.
Tests now use helper functions from eleveldb module tests.
- Number of database instances is capped to keep filesystem footprint manageable.
- Complexity of some operations reduced to limit runtime.
- Generous timeouts added to more tests.
This value is an alternative to `-mmacosx-version-min=version` which
does not appear to be settable via the snappy configure script. This is
to allow support for historical versions of MacOSX
Added flag for MACOSX_DEPLOYMENT_TARGET = 10.8
…Doug and/or emacs happy (the former is the more worthy goal).

Sync with latest 'develop' branch.
@jvf jvf mentioned this pull request Dec 11, 2019
@jvf
Copy link
Author

jvf commented Dec 11, 2019

@mergefailure I don't see a PR by you. Do you mean #254?

@mergefailure
Copy link

mergefailure commented Dec 11, 2019 via email

@jvf
Copy link
Author

jvf commented Dec 12, 2019

I saw #254 and I it would solve the problem more elegantly and would welcome if it gets merged. Given the low activity in this repo and the amount of changes in #254 my hopes for getting it merged any time soon are low.

My PR is a minimally invasive fixup to an already merged PR (#245). My hope is that this has a slightly higher chance of getting merged.

@martinsumner
Copy link
Contributor

@jvf work to resolve various compatibility/build issues have been rolled into develop-3.0. Does that branch build for you OK on OSX (it does for me)?

The develop branch is not an active branch from a riak perspective, so perhaps there shouldn't be an issue with respect to accepting PRs such as this. If you do need something merged into there, then @martincox would be the best person to raise it with.

There is a bit of a general problem with eleveldb wrt PRs and issues. There's no-one in the riak community who feels comfortable touching code (other than perhaps for very basic build changes like this). If there's someone out there who is more comfortable with pro-actively maintaining it, it might be an idea to request transfer of ownership out of the basho repo - as happened with lager and webmachine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants