Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTP21 support #259

Open
wants to merge 3 commits into
base: develop-3.0
Choose a base branch
from
Open

OTP21 support #259

wants to merge 3 commits into from

Conversation

Vagabond
Copy link
Contributor

This branch makes bitcask work (although there might be a slight performance degredation) on OTP21 and it fixes all the dialyzer warnings.

@Vagabond Vagabond requested a review from russelldb July 12, 2018 16:43
Copy link
Contributor

@evanmcc evanmcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but I no longer have a pulse license to put it through its paces

@Vagabond
Copy link
Contributor Author

I do, do you remember how to run it (or I can allocate you one for a while)?

@evanmcc
Copy link
Contributor

evanmcc commented Jul 12, 2018 via email

@Vagabond
Copy link
Contributor Author

I broke pulse support pretty bad, I need to rework it.

@hrobeers
Copy link

This works for me with Erlang/OTP 21 [erts-10.0.8] and Elixir 1.7.3

Using the dep below in my Elixir Mix file:
{:bitcask, git: "https://github.com/helium/bitcask.git", branch: "modernize"}

Thanks!

@ypaq
Copy link

ypaq commented Jun 17, 2019

Looks like the helium fork is gone. Any chance this could be merged anyhow?

@evanmcc
Copy link
Contributor

evanmcc commented Jun 17, 2019 via email

@hrobeers
Copy link

This is a clone of the helium modernize branch: https://github.com/hrobeers/bitcask

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants