Shellcheck #107
Open
Shellcheck #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ## now check what shell is running | ||
| shell_type=$(basename "$SHELL") | ||
| # shellcheck disable=SC2034 |
There was a problem hiding this comment.
What's the unused variable here?
There was a problem hiding this comment.
I think this is more that the specific variable is unknown, rather than undefined. The presence of ? would seem to indicate that the shell being used is not one of the known types and could be something else entirely.
Looking at the documentation - at least to my eyes - this looked like one of the exceptional conditions which produces a false warning, so as long as the script still works as intended, it can be ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.