Repository navigation
Report bandwidth during volume push and pull - #152
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The implementation is consistent with the stated requirements and has comprehensive command-level coverage.
0 open findings
What changed in this PR
Adds live and average bandwidth reporting to volume push/pull operations.
Changes:
- Calculates payload transfer rates and handles stalled transfers.
- Adds bandwidth to text and JSON output.
- Updates the volume SDK and expands test coverage.
| File | Description |
|---|---|
internal/cmd/command.volume_transfer.go |
Implements rate tracking and reporting. |
internal/cmd/command.volume_test.go |
Tests live, stalled, reused, and edge-case rates. |
cmd/command.volume.go |
Adds JSON bandwidth fields. |
go.mod |
Updates the volume SDK dependency. |
go.sum |
Records updated dependency checksums. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
cretz
approved these changes
Oct 14, 2026
yunzou-baseten
force-pushed
the
yzou/volume-bandwidth
branch
from
October 14, 2026 19:55
1eab210 to
018497b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 What
Show live bandwidth in volume push/pull progress and average bandwidth in the completion summary. JSON results include
average_bytes_per_second.example output
💻 How
Update the SDK dependency to use transferred-payload accounting. Calculate live rates between progress samples and refresh stalled transfers to
0 B/s.Calculate completion averages over the upload/download phase. Reused content does not inflate bandwidth; compressed downloads and retries follow the SDK's payload accounting. Existing total-time reporting remains.
🔬 Testing
Passed command-level push/pull tests with race detection.
Coverage includes live rates, stalls without further callbacks, text/JSON summaries, reused content, empty files, and zero-duration transfers.