Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New image sequence canvas #60

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

julianbenegas
Copy link
Contributor

The ImageSequenceCanvas was the first component we prototyped, and it didn't took advantage of all the primitives we created since. As such, it has a different API than the rest of the components, and we want to revise that.

Some TODOs

  • Let's make sure we handle DPR adjustment automatically
  • Let's make sure we handle aspect ratio adjustments automatically
  • ditch the required controllerRef prop in favour of handling more stuff automatically for you
    • put the Animation inside this component (receive props for this animation) so that users don't need to figure out the onUpdate stuff etc.
    • preload prop to preload images. undefined | boolean | string[]
    • we may leave the optional controllerRef prop as is so that users can use it if they choose to
  • use a Slot on top of the <canvas> so that user can do asChild and render its own <canvas>
    • potentially allow the user to target a <canvas> that's already rendered elsewhere via explicit target
  • rename to just ImageSequence

@changeset-bot
Copy link

changeset-bot bot commented Oct 15, 2023

⚠️ No Changeset found

Latest commit: 2ec44fb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
scrollytelling-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2023 4:01pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant