Skip to content

Commit

Permalink
Minor code convention and comment fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
basememara committed Oct 19, 2019
1 parent b7e7b11 commit 4cd9d85
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,10 @@ import UIKit
open class ApplicationPluggableDelegate: UIResponder, UIApplicationDelegate {
public var window: UIWindow?

/// List of application plugins for binding to `AppDelegate` events
public private(set) lazy var plugins: [ApplicationPlugin] = { application() }()

/// List of application plugins for binding to `AppDelegate` events
open func application() -> [ApplicationPlugin] {[]} // Override
}

Expand Down Expand Up @@ -113,7 +116,7 @@ extension ApplicationPluggableDelegate {
}
}

/// Conforming to an app module and added to `AppDelegate.plugins()` will trigger events.
/// Conforming to an app module and added to `AppDelegate.application()` will trigger events.
public protocol ApplicationPlugin {
func application(_ application: UIApplication, willFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?) -> Bool
func application(_ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]?) -> Bool
Expand Down
4 changes: 2 additions & 2 deletions Sources/ZamzamCore/Extensions/CLLocationManager.swift
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public extension CLLocationManager {
statuses.append(.authorized)
#endif

return CLLocationManager.locationServicesEnabled()
&& CLLocationManager.authorizationStatus().within(statuses)
return Self.locationServicesEnabled()
&& Self.authorizationStatus().within(statuses)
}
}
6 changes: 0 additions & 6 deletions Sources/ZamzamUI/Scene/AppRoutable.swift
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,7 @@ import WatchKit
public protocol AppRoutable {
#if os(iOS)
var viewController: UIViewController? { get set }

func dismiss(animated: Bool, completion: (() -> Void)?)
func dismissOrPop(animated: Bool, completion: (() -> Void)?)
func close(animated: Bool, completion: (() -> Void)?)
#elseif os(watchOS)
var viewController: WKInterfaceController? { get set }

func dismiss()
#endif
}

0 comments on commit 4cd9d85

Please sign in to comment.