ICO-245 Fix homepage loading #118
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claudiulazardd
requested review from
aheartforspinach,
m-borgmann,
mloeffle and
jkniest
as code owners
m-borgmann
reviewed
Mar 7, 2025
mloeffle
reviewed
Mar 11, 2025
| @@ -0,0 +1,13 @@ | |||
| export const useSeoUrlStore = defineStore('seoUrl', { | |||
There was a problem hiding this comment.
I don't think a Store is necessary in this case since the data is not supposed to be shared throughout multiple pages or in other words it is reset/reassigned for each page. Usage of inject/provide would be more fitting for the circumstances.
There was a problem hiding this comment.
Well it should be shared with the root of pages and the languageSwitch component which is situated in the layout. Using the context('navigation') doesn't work because ...all and the languageSwitch are siblings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the admin of the shopware configures categories with different seo-urls per language, we need to do a request do get the new seoPathInfo for the active navigation so that we can replace the url to the one which is language specific. In this way if the user refreshes the page it will get the page instead of having a 404 because it tried getting a SEO-URL for a different language.