Revert "fix(presentation-terminal): Ensure consistent ASCII logo alignment (#2260)" #2445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nment (basecamp#2260)" This reverts commit 6892304. While a hard-coded font size of 9 likely is small enough to fix the logo rendering on a large population of display configurations, it has the downside of potentially making the update terminal font painfully small since it ignores the user's configured preferences. Rather than somewhat arbitrarily drawing a hard-coded line in the sand (which still doesn't solve the issue for even smaller displays), just respect the user's preference, allowing them to easily configure a size that both looks good and doesn't warp the logo. Signed-off-by: Luke Hsiao <[email protected]>
|
Going to need something that solves the original issue, if we're going to remove the 9pt fix. Maybe there's a way to prevent things from wrapping? But I'd rather have something that looks a little small than something that looks fully broken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert "fix(presentation-terminal): Ensure consistent ASCII logo alignment (#2260)"
This reverts commit 6892304.
While a hard-coded font size of 9 likely is small enough to fix the logo
rendering on a large population of display configurations, it has the
downside of potentially making the update terminal font painfully small
since it ignores the user's configured preferences.
Rather than somewhat arbitrarily drawing a hard-coded line in the sand
(which still doesn't solve the issue for even smaller displays), just
respect the user's preference, allowing them to easily configure a size
that both looks good and doesn't warp the logo.
Signed-off-by: Luke Hsiao [email protected]
Example of the extremely small size-9 font on some displays
Ref: #2260