Skip to content

Add table extension to mdConverter goldmark renderer#498

Open
savtrip wants to merge 1 commit into
basecamp:mainfrom
savtrip:patch-1
Open

Add table extension to mdConverter goldmark renderer#498
savtrip wants to merge 1 commit into
basecamp:mainfrom
savtrip:patch-1

Conversation

@savtrip

@savtrip savtrip commented Jun 11, 2026

Copy link
Copy Markdown

What

Hi guys,

This adds the goldmark table extension for rendering markdown tables to HTML that lexxy now supports in bc5.

Here are the docs for the table extension that I added: https://pkg.go.dev/github.com/yuin/goldmark#readme-built-in-extensions

Why

My agent was adding tables to descriptions of cards and todos (any rich text area) but I noticed the table was not rendering but instead showed the raw markdown.

Therefore, I looked into the code and discovered there was no table extension for goldmark (refer to the docs I linked above to see the table extension). Also, I noticed from the comment it says:

// mdConverter is the goldmark Markdown-to-HTML converter configured for Trix compatibility.

Therefore, I assume the team has not optimised for lexxy yet given it says Trix.

If my agent renders everything in HTML then the table works fine. But sometimes it chooses to do it in markdown and therefore I end up having the raw markdown content in my rich text (which obviously looks terrible lol).

If for whatever reason you guys aren't happy with the change then writing something in the SKILL file to say "Note: tables will not render if provided in markdown because the CLI does not convert them to HTML" would at least signal to the agent that it's not possible.

Testing

  • make check passes

I did not add any test cases in. I performed a cli test of adding a card and it worked successful. I did not want to add tests because I wanted to check if this was a change you guys were happy with.

EDIT: Screenshots

I added the screenshots below to show the problem in basecamp.

HTML

screenshot-2026-06-11-at-12-43-23

Markdown

screenshot-2026-06-11-at-12-42-44

Summary by cubic

Enable Markdown table rendering by adding the goldmark table extension to the Markdown-to-HTML converter. Tables in rich text now render as HTML instead of showing raw Markdown.

Written for commit 612b3f8. Summary will update on new commits.

Review in cubic

Copilot AI review requested due to automatic review settings June 11, 2026 11:25
@github-actions github-actions Bot added the enhancement New feature or request label Jun 11, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds Markdown table support to the rich-text Markdown→HTML converter.

Changes:

  • Enable Goldmark’s extension.Table alongside extension.Strikethrough

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

// mdConverter is the goldmark Markdown-to-HTML converter configured for Trix compatibility.
var mdConverter = goldmark.New(
goldmark.WithExtensions(extension.Strikethrough),
goldmark.WithExtensions(extension.Strikethrough, extension.Table),

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@flavorjones

Copy link
Copy Markdown
Member

Thanks for this. Just wanted to drop a note that the eventual goal is to have markdown conversion done server-side (not in the CLI). But that's going to be a few more weeks at least, so it may make sense to add this client-side for now. I'll defer to @jeremy!

@savtrip

savtrip commented Jun 11, 2026

Copy link
Copy Markdown
Author

No worries Mike, thanks for the explanation, I was wondering why the conversion was done locally instead of server-side, makes sense now. Appreciate your help, have a great day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants