replaces the configure shell script with AWS SDK #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronwalker
force-pushed
the
ciinabox_vpc_params
branch
from
2a0ec30
to
f443f42
Compare
Guslington
suggested changes
Aug 16, 2018
| @@ -76,6 +76,7 @@ def call(body) { | |||
| ''' | |||
| sh '''#!/bin/bash | |||
| AMI_BUILD_ID=${BRANCH}-${AMI_BUILD_NUMBER} | |||
| export OPT_VARS="-var ami_users=${AMI_USERS}" | |||
There was a problem hiding this comment.
what happens if this this is a null value? Would this be better off being added to the bakery script with the rest of the options?
aaronwalker
force-pushed
the
ciinabox_vpc_params
branch
from
29bec62
to
ac91d4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.