Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: useTheme check by removing default context value #2156

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ursulabauer
Copy link

What changed? Why?
Removed the default value from ThemeContext (theme: 'dark', toggleTheme: () => {}) because it made useContext(ThemeContext) always return an object, making the useTheme check useless. Now, ThemeContext is initialized with null, allowing the check to work properly when ThemeProvider is missing.

Notes to reviewers
This ensures useTheme throws an error when used outside ThemeProvider, as originally intended. Let me know if you see any edge cases I might have missed.

How has it been tested?
Manually tested by rendering a component using useTheme inside and outside ThemeProvider to confirm the expected behavior.

Have you tested the following pages?

BaseWeb

  • base.org
  • base.org/names
  • base.org/builders
  • base.org/ecosystem
  • base.org/name/jesse
  • base.org/manage-names
  • base.org/resources

BaseDocs

  • docs.base.org
  • docs sub-pages

Copy link

vercel bot commented Apr 2, 2025

@ursulabauer is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall
Copy link
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants