fix: Removed unnecessary check in useTheme()
#2153
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
The
if (context === undefined)
check inuseTheme()
was removed. This check was unnecessary becauseuseContext(ThemeContext)
never returnsundefined
—it always provides a value fromcreateContext()
. If no provider is found, the default value is used. This change makes the code cleaner and more logical.Notes to reviewers
This is a minor cleanup to remove redundant logic. No functional changes expected.
How has it been tested?
Checked that the theme logic still works as expected without the unnecessary check.
Have you tested the following pages?
BaseWeb
BaseDocs