fix: incorrect match length check in getGatewayUrl #2152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
I fixed an issue in the
getGatewayUrl
function wherematch.length
was being accessed. This was problematic becauseexec()
can returnnull
, and trying to checkmatch.length
would cause aTypeError
. I replaced the check to ensure thatmatch[2]
exists, which is safer and prevents errors.Notes to reviewers
Please review the change to ensure the check is now more robust and does not break functionality. It would be great if you could check other parts of the codebase that might rely on the
getGatewayUrl
function to confirm no other issues are present.How has it been tested?
The code has been tested locally to confirm that the issue is resolved and no TypeErrors occur when
match
isnull
.Have you tested the following pages?
BaseWeb
BaseDocs