Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Base Docs V2 #1784

Merged
merged 31 commits into from
Feb 20, 2025
Merged

Feat: Base Docs V2 #1784

merged 31 commits into from
Feb 20, 2025

Conversation

brendan-defi
Copy link
Collaborator

@brendan-defi brendan-defi commented Feb 19, 2025 •
edited
Loading

What changed? Why?

  • Replace apps/base-docs Docusaurus site with Vocs
  • Add Google Analytics

coauthors:

Notes to reviewers

How has it been tested?

  • vercel previews
  • manual pressure testing / link testing

@vercel Vercel
Copy link

vercel bot commented Feb 19, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2025 4:11pm
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2025 4:11pm

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Feb 19, 2025 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@github-actions GitHub Actions
Copy link

⚠️ File Size Check Results

⚠️ Large Files (Over 10MB):

  • apps/base-docs/docs/public/images/build-with-thirdweb/car-color-nft.gif (14.91MB)

Consider reducing the size of these files if possible.

@github-actions GitHub Actions
Copy link

⚠️ File Size Check Results

⚠️ Large Files (Over 10MB):

  • apps/base-docs/docs/public/images/build-with-thirdweb/car-color-nft.gif (14.91MB)

Consider reducing the size of these files if possible.

@github-actions GitHub Actions
Copy link

⚠️ File Size Check Results

⚠️ Large Files (Over 10MB):

  • apps/base-docs/docs/public/images/build-with-thirdweb/car-color-nft.gif (14.91MB)

Consider reducing the size of these files if possible.

@github-actions GitHub Actions
Copy link

⚠️ File Size Check Results

⚠️ Large Files (Over 10MB):

  • apps/base-docs/docs/public/images/build-with-thirdweb/car-color-nft.gif (14.91MB)

Consider reducing the size of these files if possible.

@github-actions GitHub Actions
Copy link

⚠️ File Size Check Results

⚠️ Large Files (Over 10MB):

  • apps/base-docs/docs/public/images/build-with-thirdweb/car-color-nft.gif (14.91MB)

Consider reducing the size of these files if possible.

@github-actions GitHub Actions
Copy link

⚠️ File Size Check Results

⚠️ Large Files (Over 10MB):

  • apps/base-docs/docs/public/images/build-with-thirdweb/car-color-nft.gif (14.91MB)

Consider reducing the size of these files if possible.

@github-actions GitHub Actions
Copy link

⚠️ File Size Check Results

⚠️ Large Files (Over 10MB):

  • apps/base-docs/docs/public/images/build-with-thirdweb/car-color-nft.gif (14.91MB)

Consider reducing the size of these files if possible.

@brendan-defi brendan-defi mentioned this pull request Feb 20, 2025
Closed
@brendan-defi brendan-defi changed the title Bf/docs2 Feat: Base Docs V2 Feb 20, 2025
@brendan-defi brendan-defi merged commit 7728869 into master Feb 20, 2025
9 checks passed
@brendan-defi brendan-defi deleted the bf/docs2 branch February 20, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschlabach dschlabach dschlabach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brendan-defi @cb-heimdall @dschlabach @ericbrown99