Open
Conversation
Collaborator
✅ Heimdall Review Status
|
and-cb
force-pushed
the
andrea/deferred-rlp-hash-write
branch
from
708c187 to
c22c407
Compare
and-cb
changed the base branch from
main
to
andrea/storage-engine-threadpool
and-cb
force-pushed
the
andrea/deferred-rlp-hash-write
branch
5 times, most recently
from
fd831a3 to
cb303bf
Compare
and-cb
force-pushed
the
andrea/deferred-rlp-hash-write
branch
from
cb303bf to
cc63dcf
Compare
and-cb
force-pushed
the
andrea/storage-engine-threadpool
branch
from
93115b9 to
0d14745
Compare
kmchicoine
approved these changes
Nov 14, 2025
Collaborator
|
Review Error for kmchicoine @ 2025-11-14 21:31:54 UTC |
kmchicoine
approved these changes
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes hash computations happen in parallel in a thread pool. While hashes are computed in the background, a temporary, zero-byte hash is written to the pages. The zero hashes are replaced with the actual hashes once all changes have been processed.
Status of this PR: All tests are passing, but this is a very early draft that needs a lot of cleanup and refactoring.