Skip to content

Conversation

@savvar9991
Copy link

Summary

Standardizes request parameters to camelCase for TIPS Bundle compatibility and adds blockNumber fallback for accurate simulation state. This ensures zero parse errors and precise gas/time metrics for MEV bidding.

Changes

  • Params: Converted snake_case to camelCase (e.g., min_timestampminTimestamp, revertingTxHashes, flashblockNumberMin/Max, droppingTxHashes) to match JSON-RPC/Web3 standards and TIPS format .
  • blockNumber: Updated description to "Block number for simulation state (falls back to 'latest' if invalid)" for reliable state forking.
  • Returns: Added requestedBlockNumber field for logging/debugging requested vs actual block; updated stateBlockNumber description for transparency on fallback.
  • Note/Implementation: Retained ignored fields (e.g., revertingTxHashes) with clear warning; "Stops on first failure" aligns with eth_callBundle revert handling.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Nov 13, 2025

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@savvar9991 savvar9991 changed the title standardize TIPS params to camelCase and add blockNumber fallback fix: standardize TIPS params to camelCase and add blockNumber fallback Nov 13, 2025
@savvar9991
Copy link
Author

Hi @danyalprout!
Could you please take a quick look at this PR ?
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants