Skip to content

Conversation

@jackchuma
Copy link
Contributor

The DoubleNestedMultisigBuilder script was incorrectly sharing link generation logic with NestedMultisigBuilder resulting in disregarded state diff(s) for the child signer contract. This is needed for Upgrade 15 which is planned to be executed tomorrow. As a result of the time crunch, I just copy/pasted the relevant functions into DoubleNestedMultisigBuilder that are seen below. These are taken / modified from NestedMultisigBase.sol. Some logic is still shared so this can be refactored in a later PR.

Here's the diff for relevant functions that were modified while adding to DoubleNestedMultisigBuilder
Screenshot 2025-04-15 at 7 45 49 PM
Screenshot 2025-04-15 at 7 46 02 PM

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Apr 15, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@mdehoog mdehoog merged commit e6bfc86 into main Apr 16, 2025
2 checks passed
@mdehoog mdehoog deleted the jack/fix-double-nested-builder branch April 16, 2025 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants