update template for fault proof upgrade resulting in new absolute prestate #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Heimdall Review Status
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the upgrade template for fault proofs by modifying compiler settings and removing outdated validation documentation.
- Adjusted the optimizer configuration in foundry.toml and removed the explicit solc_version setting.
- Removed the outdated VALIDATION.md file that detailed state validation instructions.
Reviewed Changes
Copilot reviewed 2 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| setup-templates/template-upgrade-fault-proofs/foundry.toml | Updated optimizer_runs value and removed solc_version pinning to reflect new compilation requirements. |
| setup-templates/template-upgrade-fault-proofs/VALIDATION.md | Removed outdated documentation for state validation. |
Files not reviewed (4)
- setup-templates/template-upgrade-fault-proofs/.env: Language not supported
- setup-templates/template-upgrade-fault-proofs/Makefile: Language not supported
- setup-templates/template-upgrade-fault-proofs/script/DeployDisputeGames.s.sol: Language not supported
- setup-templates/template-upgrade-fault-proofs/script/UpgradeDGF.s.sol: Language not supported
Comments suppressed due to low confidence (3)
setup-templates/template-upgrade-fault-proofs/foundry.toml:7
- The solc_version pinning has been removed, which could lead to unexpected compiler version behavior. Consider specifying a compiler version to ensure consistent compilation.
solc_version = "0.8.15"
setup-templates/template-upgrade-fault-proofs/VALIDATION.md:1
- The removal of the VALIDATION.md file deletes previously provided state validation guidelines. Confirm that the essential validation instructions have been migrated or are no longer required.
Deleted file VALIDATION.md
setup-templates/template-upgrade-fault-proofs/foundry.toml:8
- [nitpick] The optimizer_runs value has been significantly decreased from 999999 to 200; please confirm that this change is intentional and that the new value meets your performance and optimization expectations.
optimizer_runs = 200
henridevieux
approved these changes
Apr 18, 2025
mdehoog
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes out-of-date contracts and adds necessary Makefile commands. Refers to https://github.com/base/contract-deployments/tree/main/sepolia/2025-04-14-upgrade-fault-proofs