Skip to content

feat(CHAIN-548): add script for SmartEscrow ownership transfer initiation #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 8, 2025

Conversation

jackchuma
Copy link
Contributor

We wish to update the owner of our SmartEscrow contract on OP Mainnet to be the aliased address of our L1 ProxyAdminOwner. The SmartEscrow contract inherits access control mechanisms from OpenZeppelin's AccessControlDefaultAdminRules, which requires an ownership transfer to be invoked in two separate steps:

  1. Initiate the transfer to a new owner from the existing owner
  2. Accept the transfer from the pending new owner after a configured delay

This task represents the initiation step. A subsequent task will be written for ownership acceptance after a 5 day delay.

@jackchuma jackchuma requested a review from Copilot April 8, 2025 12:14
@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Apr 8, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 2/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@jackchuma jackchuma requested review from xenoliss and cbfyi April 8, 2025 12:14
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 6 changed files in this pull request and generated 1 comment.

Files not reviewed (3)
  • mainnet/2025-04-07-init-smart-escrow-ownership-transfer/.env: Language not supported
  • mainnet/2025-04-07-init-smart-escrow-ownership-transfer/Makefile: Language not supported
  • mainnet/2025-04-07-init-smart-escrow-ownership-transfer/script/InitOwnershipTransfer.s.sol: Language not supported

@jackchuma jackchuma merged commit 79d78a6 into main Apr 8, 2025
4 checks passed
@jackchuma jackchuma deleted the jack/update-smart-escrow-ownership branch April 8, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants