Skip to content

feat: add additional validation checks for DisputeGameFactory upgrade #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add additional validation checks for DisputeGameFactory upgrade #278

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions setup-templates/template-upgrade-fault-proofs/script/UpgradeDGF.s.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,17 @@ contract UpgradeDGF is NestedMultisigBuilder {
_precheckDisputeGameImplementation(GameTypes.CANNON, fdgImpl);
_precheckDisputeGameImplementation(GameTypes.PERMISSIONED_CANNON, pdgImpl);
// TODO: Add extra pre-checks here

// Check that the new implementations are valid contracts
require(fdgImpl.code.length > 0, "FDG implementation is not a contract");
require(pdgImpl.code.length > 0, "PDG implementation is not a contract");

// Check that the owner of the DisputeGameFactory is correct
require(dgfProxy.owner() == _OWNER_SAFE, "DGF owner is not the expected owner");

// Verify that the implementations are different from the current ones
require(address(dgfProxy.gameImpls(GameTypes.CANNON)) != fdgImpl, "New FDG implementation is the same as current");
require(address(dgfProxy.gameImpls(GameTypes.PERMISSIONED_CANNON)) != pdgImpl, "New PDG implementation is the same as current");
}

// Checks that the new game being set has the same configuration as the existing implementation with the exception
Expand Down Expand Up @@ -84,6 +95,21 @@ contract UpgradeDGF is NestedMultisigBuilder {
_postcheckHasAnchorState(GameTypes.CANNON);
_postcheckHasAnchorState(GameTypes.PERMISSIONED_CANNON);
// TODO: Add extra post-checks here

// Verify that the implementations are correctly set
FaultDisputeGame fdgImplContract = FaultDisputeGame(fdgImpl);
PermissionedDisputeGame pdgImplContract = PermissionedDisputeGame(pdgImpl);

// Check that the implementations have the correct version
require(fdgImplContract.version() > 0, "FDG implementation has invalid version");
require(pdgImplContract.version() > 0, "PDG implementation has invalid version");

// Verify that the implementations are initialized
require(fdgImplContract.initialized(), "FDG implementation is not initialized");
require(pdgImplContract.initialized(), "PDG implementation is not initialized");

// Check that the game types are correctly registered
require(dgfProxy.gameCount() >= 2, "DGF should have at least 2 game types registered");
}

// Checks the anchor state for the source game type still exists after re-initialization. The actual anchor state
Expand Down