Skip to content

chore: run benchmark in CI #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 8, 2025
Merged

chore: run benchmark in CI #18

merged 6 commits into from
Apr 8, 2025

Conversation

meyer9
Copy link
Collaborator

@meyer9 meyer9 commented Apr 7, 2025

Description

Runs a basic benchmark in CI

Testing

Tested in CI

@meyer9 meyer9 marked this pull request as ready for review April 7, 2025 23:26
@meyer9 meyer9 marked this pull request as draft April 7, 2025 23:26
@meyer9 meyer9 marked this pull request as ready for review April 8, 2025 03:58
chmod +x ${{ runner.temp }}/bin/reth

git clone https://github.com/ethereum-optimism/op-geth
cd op-geth

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe cleaner to use git -C op-geth ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good suggestion! Added

@meyer9 meyer9 force-pushed the meyer9/run-benchmark-ci branch from c4ab8b7 to 7ff4b41 Compare April 8, 2025 15:05
@meyer9 meyer9 changed the base branch from meyer9/improve-ci-linter to main April 8, 2025 15:06
@cb-heimdall
Copy link
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@meyer9 meyer9 merged commit 52716b6 into main Apr 8, 2025
1 check was pending
@meyer9 meyer9 deleted the meyer9/run-benchmark-ci branch April 15, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants