Added regex pattern option #2
Open
+10
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ArthurClemens You might be interested in mark.js, which has a method for this implemented. |
|
After almost 5 years, I cannot remember this. |
|
I can understand |
Just saying, maybe this is an issues for others at present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The \b delimiter pattern does not work well with non-english languages. It should actually be '(^| )' + searchString + '(?= |$)' - this should be changed in the file as well.
But to make the matching more flexible than just 'wordsOnly' I created an option to pass a regular expression pattern. That way I can make the highlighting match the actual search query, for instance "all words ending on 'an'".