Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all "note" in README apply quote style #1590

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make all "note" in README apply quote style #1590

wants to merge 1 commit into from

Conversation

hms5232
Copy link

@hms5232 hms5232 commented Oct 1, 2024

Summary

Make all "note" in README apply quote style. Now, those "note" stand out in text sea.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Misc. change (internal, infrastructure, maintenance, etc.)

Checklist

  • Existing tests have been adapted and/or new tests have been added
  • Add a CHANGELOG.md entry
  • Update the README.md
  • Code style has been fixed via composer fix-style

@hms5232
Make all "note" in README apply quote style
443acd6 
Now, those "note" stand out in text sea
mfn
mfn approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfn mfn mfn approved these changes

Assignees

@barryvdh barryvdh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hms5232 @mfn @barryvdh