Removed support for Laravel 8 and therefore for PHP < 8.0 #1504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfn
commented
Jan 28, 2024
Comment on lines
-4
to
+6
| /.php_cs | ||
| /.php_cs.cache | ||
| /.php_cs.tests.cache | ||
| /.php-cs-fixer.cache | ||
| /.php-cs-fixer.php | ||
| /.php-cs-fixer.tests.cache |
There was a problem hiding this comment.
With the upgrade to php-cs-fixer v3, the default file names changed (and was required to be renamed), I therefore adapted all of them
| @@ -30,7 +30,6 @@ | |||
| ], | |||
| 'return_type_declaration' => true, | |||
| 'short_scalar_cast' => true, | |||
| 'single_blank_line_before_namespace' => true, | |||
There was a problem hiding this comment.
Deprected and going to be removed in the future -> https://cs.symfony.com/doc/rules/namespace_notation/single_blank_line_before_namespace.html
This comment was marked as resolved.
This comment was marked as resolved.
mfn
force-pushed
the
mfn-laravel-8-out
branch
2 times, most recently
from
36daf67 to
47bb9f4
Compare
mfn
force-pushed
the
mfn-laravel-8-out
branch
from
47bb9f4 to
ece9d73
Compare
|
@barryvdh this should be good now! The source file changes are all due to php-cs-fixer upgrade to v3 |
barryvdh
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After pushing out 2.14.0, I propose we get rid of baggage and remove support for Laravel 8, which had had its EOL a year ago already.
Updated README, removed some legacy checks for < L8 in lib code and tests
fix-styleapplied some mostly cosmetic changes, which made out the bulk of the diff in the endType of change
Checklist
composer fix-style