Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MUI v5 #12

Open
wants to merge 39 commits into
base: master
Choose a base branch
from
Open

MUI v5 #12

wants to merge 39 commits into from

Conversation

Zenoo
Copy link

@Zenoo Zenoo commented Apr 6, 2022

This PR works on bringing MUI v5 to the repo.

I'm having some issues with the ts config for this repo:

I'm also fixing some Typescript issues as I see them.
I will update this PR when the upgrade is done.

@Zenoo
Copy link
Author

Zenoo commented Apr 6, 2022

The main work is done.
All there is left is removing every useStyles and replacing them with the sx prop.
I'm doing that right now.

Another error I can't seem to fix is in the website editor:

@Zenoo
Copy link
Author

Zenoo commented Apr 6, 2022

Alright, I fixed the error in the Monaco editor.
Only the usestyles left.

@Zenoo Zenoo marked this pull request as ready for review April 7, 2022 08:31
@Zenoo
Copy link
Author

Zenoo commented Apr 7, 2022

Everything should be done!

Fix tab color by swapping AppBar with Box
@shadoath
Copy link

shadoath commented Sep 3, 2022

This looks really sweet @bareynol any plans to merge this and give users the option to swap between v4 and v5?

@Zenoo
Copy link
Author

Zenoo commented Sep 3, 2022

@shadoath You can already do that by accessing the usual URL for v4, and the URL from my fork for v5

@shadoath
Copy link

shadoath commented Sep 6, 2022

@Zenoo thank you I have bookmarked your repo!

Looking at the number of changes I now realize that there is no way to have both the v4 and v5 MUI active at the same time.

@vfproductions
Copy link

I mde a fork and fixed a few minor things for v5, but im a github noob so dont know what to do with it. Its here https://github.com/vfproductions/mui-theme-creator

@Zenoo
Copy link
Author

Zenoo commented Sep 6, 2022

@vfproductions You can imply open a PR on my fork https://github.com/Zenoo/mui-theme-creator/pulls

@vfproductions
Copy link

@Zenoo yep nevermnind.. I already did that, and you completed it, and it's showing up here, so all is good. Just not used to seeing commits in ascending order. Weird

@vfproductions
Copy link

I did have one more small thing to PR, see Zenoo#4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants