Fix Requests to Work With Later Versions of The Ruby HTTP Gem #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier versions of HTTP did the conversion this but this is no longer the case.
sshaw
changed the title
Contributor
Author
|
Also I would wait to do a release until I'm done with my upgrade in case something else comes up. |
Contributor
Author
|
Alrighty @barelyknown, been using this for a few months now no issues. |
Often times the gendered servers return a non-JSON response (50[23]). Instead of attempting to parse it and getting a parse error we raise our own error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier versions of HTTP did the conversion this but this is no longer
the case.
Also removed the warning from the README since the code has not been updated since my last commits (2015) and I've been using it in production since then (though in the process of upgrading the app to Rails 5 and Ruby 2.5 😏 and found this issue).