Add call number action #1698
Draft
Add call number action #1698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This patch adds the ability to call numbers just like sending e-mails. Instead of
mailtoit uses theteluri scheme (see https://tools.ietf.org/html/rfc3966). On Windows 10 this prompts for a phone app which could be "MyPhone" app or a softphone like MicroSIP (tested). Support for tel-uris is whacky, but seems to get more common. The patch assumes phone numbers are entered in a RFC3966 compliant-ish with only minimal sanitation done in XSLTs.Todo: