Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Info.plist.patch #1323

Open
wants to merge 7 commits into
base: BRANCH_2_7_X
Choose a base branch
from
Open

Update Info.plist.patch #1323

wants to merge 7 commits into from

Conversation

ryanthara
Copy link

Add retina display support for OSX.

More information about the retina display can be found on Apple Developer websites.

This will close this issue.

Copy link
Contributor

@dbarashev dbarashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sebastian, thanks for the patch. I can't test it immediately because I have no access to Mac Book with retina display, but I trust that it fixes the issue.

Just one moment: can you make a pull request against BRANCH_2_7_X instead of master? BRANCH_2_7_X is a stable branch, and I'd like to merge stable into master later, rather than merge or cherry-pick from master into stable branch.

Thanks!

@ryanthara ryanthara changed the base branch from master to BRANCH_2_7_X November 29, 2016 00:13
@ryanthara
Copy link
Author

Hello Dmitry

Appreciate. It is working here on my MBP and shows the high resolution.

@dbarashev
Copy link
Contributor

Hi,
this base branch change is not exactly what I meant.

I meant that you do in your local repository

git checkout BRANCH_2_7_X
# add your changes
git commit -a
git push origin BRANCH_2_7_X

and then create a pull request where base is bardsoftware:BRANCH_2_7_X and from is ryanthara:BRANCH_2_7_X

However, if you feel that it is too much for a one line change and don't care about your activity history ;) then I can add it appropriately myself.

@ryanthara
Copy link
Author

ryanthara commented Nov 29, 2016 via email

dbarashev pushed a commit that referenced this pull request Nov 30, 2016
thanks to @ryanthara for the patch
See original pull request: pr:#1323
@dbarashev
Copy link
Contributor

I have commmited this change myself. You can download the build with this change applied from Dropbox: https://www.dropbox.com/sh/0gwuayq6vg0kyss/AAApogLPlvpg0lY9JltS-3sZa?dl=0 (there is zipped GanttProject.app)

@ryanthara
Copy link
Author

Your implementation doesn't work. The NSHighResolutionCapable is not on the right position and therefore the version on the dropbox doesn't start in retina mode. Although the window opens on the bottom left corner in minimised view. :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants