Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tracing config to api #930

Merged
merged 5 commits into from
Jan 26, 2024
Merged

add tracing config to api #930

merged 5 commits into from
Jan 26, 2024

Conversation

waynz0r
Copy link
Member

@waynz0r waynz0r commented Jan 26, 2024

Q A
Bug fix? no
New feature? yes
API breaks? no
Deprecations? no
Related tickets
License Apache 2.0

What's in this PR?

It adds tracing configuration to the CRD API.

spec:
  proxy:
    tracer: "zipkin"

  tracer:
    zipkin:
      address: zipkin.istio-system:9410

Why?

Currently there is no way to properly configure the tracing settings for the proxies.

Checklist

  • Implementation tested
  • Error handling code meets the guideline
  • Logging code meets the guideline

Laci21
Laci21 previously approved these changes Jan 26, 2024
View reviewed changes
Laci21
Laci21 previously approved these changes Jan 26, 2024
View reviewed changes
@waynz0r waynz0r merged commit 9ff38bb into release-1.17 Jan 26, 2024
5 checks passed
@waynz0r waynz0r deleted the add-trace-config branch January 26, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Laci21 Laci21 Laci21 left review comments

@martonsereg martonsereg Awaiting requested review from martonsereg martonsereg is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@waynz0r @Laci21