address review comments

api/v1alpha1/common.gen.json

@@ -319,12 +319,12 @@
             "nullable": true
           },
           "max": {
-            "description": "max is the upper limit for the number of replicas to which the autoscaler can scale up. min and max both needs to be set the turn on autoscaling. It cannot be less that min.",
+            "description": "max is the upper limit for the number of replicas to which the autoscaler can scale up. min and max both need to be set the turn on autoscaling. It cannot be less than min.",
             "type": "integer",
             "nullable": true
           },
           "min": {
-            "description": "min is the lower limit for the number of replicas to which the autoscaler can scale down. min and max both needs to be set the turn on autoscaling.",
+            "description": "min is the lower limit for the number of replicas to which the autoscaler can scale down. min and max both need to be set the turn on autoscaling.",
             "type": "integer",
             "nullable": true
           },

api/v1alpha1/common.pb.html

@@ -1275,7 +1275,7 @@ <h2 id="Replicas">Replicas</h2>
 <td>
 <p>min is the lower limit for the number of replicas to which the autoscaler
 can scale down.
-min and max both needs to be set the turn on autoscaling.
+min and max both need to be set the turn on autoscaling.
 +kubebuilder:validation:Minimum=0</p>
 
 </td>
@@ -1288,8 +1288,8 @@ <h2 id="Replicas">Replicas</h2>
 <td><code><a href="https://developers.google.com/protocol-buffers/docs/reference/google.protobuf#int32value">Int32Value</a></code></td>
 <td>
 <p>max is the upper limit for the number of replicas to which the autoscaler can scale up.
-min and max both needs to be set the turn on autoscaling.
-It cannot be less that min.
+min and max both need to be set the turn on autoscaling.
+It cannot be less than min.
 +kubebuilder:validation:Minimum=1</p>
 
 </td>

api/v1alpha1/common.proto

@@ -540,13 +540,13 @@ message Replicas {
 
     // min is the lower limit for the number of replicas to which the autoscaler
     // can scale down.
-    // min and max both needs to be set the turn on autoscaling.
+    // min and max both need to be set the turn on autoscaling.
     // +kubebuilder:validation:Minimum=0
     google.protobuf.Int32Value min = 2 [(gogoproto.wktpointer) = true];
 
     // max is the upper limit for the number of replicas to which the autoscaler can scale up.
-    // min and max both needs to be set the turn on autoscaling.
-    // It cannot be less that min.
+    // min and max both need to be set the turn on autoscaling.
+    // It cannot be less than min.
     // +kubebuilder:validation:Minimum=1
     google.protobuf.Int32Value max = 3 [(gogoproto.wktpointer) = true];
 

api/v1alpha1/istiocontrolplane.gen.json

@@ -2313,12 +2313,12 @@
             "nullable": true
           },
           "max": {
-            "description": "max is the upper limit for the number of replicas to which the autoscaler can scale up. min and max both needs to be set the turn on autoscaling. It cannot be less that min.",
+            "description": "max is the upper limit for the number of replicas to which the autoscaler can scale up. min and max both need to be set the turn on autoscaling. It cannot be less than min.",
             "type": "integer",
             "nullable": true
           },
           "min": {
-            "description": "min is the lower limit for the number of replicas to which the autoscaler can scale down. min and max both needs to be set the turn on autoscaling.",
+            "description": "min is the lower limit for the number of replicas to which the autoscaler can scale down. min and max both need to be set the turn on autoscaling.",
             "type": "integer",
             "nullable": true
           },

api/v1alpha1/istiomeshgateway.gen.json

@@ -331,12 +331,12 @@
             "nullable": true
           },
           "max": {
-            "description": "max is the upper limit for the number of replicas to which the autoscaler can scale up. min and max both needs to be set the turn on autoscaling. It cannot be less that min.",
+            "description": "max is the upper limit for the number of replicas to which the autoscaler can scale up. min and max both need to be set the turn on autoscaling. It cannot be less than min.",
             "type": "integer",
             "nullable": true
           },
           "min": {
-            "description": "min is the lower limit for the number of replicas to which the autoscaler can scale down. min and max both needs to be set the turn on autoscaling.",
+            "description": "min is the lower limit for the number of replicas to which the autoscaler can scale down. min and max both need to be set the turn on autoscaling.",
             "type": "integer",
             "nullable": true
           },

internal/assets/manifests/istio-discovery/templates/autoscale.yaml

@@ -19,6 +19,6 @@ spec:
   - type: Resource
     resource:
       name: cpu
-      targetAverageUtilization: {{ default 80 .Values.pilot.cpu.targetAverageUtilization }}
+      targetAverageUtilization: {{ .Values.pilot.cpu.targetAverageUtilization }}
 ---
 {{- end }}

internal/assets/manifests/istio-meshgateway/templates/autoscale.yaml

@@ -18,6 +18,6 @@ spec:
     - type: Resource
       resource:
         name: cpu
-        targetAverageUtilization: {{ default 80 $gateway.replicas.targetCPUUtilizationPercentage }}
+        targetAverageUtilization: {{ $gateway.replicas.targetCPUUtilizationPercentage }}
 ---
 {{- end }}

internal/assets/manifests/istio-meshgateway/values.yaml

@@ -25,6 +25,7 @@ deployment:
     count: 1
     min: 1
     max: 1
+    targetCPUUtilizationPercentage: 80
   resources:
     limits:
       cpu: "2"