Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade aws sdk #345

Merged
merged 2 commits into from
Jul 15, 2020
Merged

Upgrade aws sdk #345

merged 2 commits into from
Jul 15, 2020

Conversation

sagikazarmark
Copy link
Member

Q A
Bug fix? no
New feature? no
API breaks? no
Deprecations? no
Related tickets
License Apache 2.0

What's in this PR?

Upgrade AWS SDK

Why?

The gov cloud region description is old in the currently used version.

lpuskas
lpuskas approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@lpuskas lpuskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sagikazarmark sagikazarmark merged commit b02ef63 into master Jul 15, 2020
@sagikazarmark sagikazarmark deleted the upgrade-aws-sdk branch July 15, 2020 11:32
@mrsheepuk mrsheepuk mentioned this pull request Aug 5, 2020
Closed
@bandesz
Copy link
Contributor

bandesz commented Aug 5, 2020 •
edited
Loading

@lpuskas @sagikazarmark this change possibly broke the AWS pricing, affecting all EU regions: #365

@sagikazarmark
Copy link
Member Author

Thanks! We are looking into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpuskas lpuskas lpuskas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sagikazarmark @bandesz @lpuskas