Skip to content

Commit

Permalink
feat: added linux GOOS to fixKind0_9_0KubeProxy
Browse files Browse the repository at this point in the history
  • Loading branch information
akijakya committed Aug 9, 2022
1 parent 4ad83a8 commit 2702884
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions internal/cli/command/controlplane/kind.go
Original file line number Diff line number Diff line change
Expand Up @@ -190,10 +190,10 @@ func ensureKINDCluster(banzaiCli cli.Cli, options *cpContext, listenAddress stri
}
}

if runtime.GOOS == "darwin" {
err = fixKind0_8_1KubeProxy(kubeconfig)
if runtime.GOOS == "darwin" || runtime.GOOS == "linux" {
err = fixKind0_9_0KubeProxy(kubeconfig)
if err != nil {
return errors.Wrap(err, "failed to fix Kind v0.8.1 kube-proxy CrashLoopBackoff")
return errors.Wrap(err, "failed to fix Kind v0.9.0 kube-proxy CrashLoopBackoff")
}
}

Expand All @@ -216,13 +216,13 @@ func deleteKINDCluster(banzaiCli cli.Cli) error {
return nil
}

// fixKind0_8_1KubeProxy returns an error if failed, otherwise fixes the Kind
// fixKind0_9_0KubeProxy returns an error if failed, otherwise fixes the Kind
// v0.8.1 kube-proxy issue of
// https://github.com/kubernetes-sigs/kind/issues/2240 on macOS without
// https://github.com/kubernetes-sigs/kind/issues/2240 on macOS and linux without
// requiring Kind upgrade to v0.11.1 / because that would pull in K8s client
// v0.21 upgrade which breaks bank-vaults 1.3 and would require bank-vaults 1.13
// which would pull in a lot of changes.
func fixKind0_8_1KubeProxy(kubeconfig []byte) error {
func fixKind0_9_0KubeProxy(kubeconfig []byte) error {
namespace := "kube-system"
configMapName := "kube-proxy"
configFileName := "config.conf"
Expand Down

0 comments on commit 2702884

Please sign in to comment.